fix: repair all failing tests in utility library#214
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: wordCount splits on whitespace regex; implement truncate - task-manager: implement remove/update return values and sortBy ordering - date-utils: formatRelative uses Math.round for day boundary (36h -> 2 days) - validator: isEmail accepts long TLDs; isUrl accepts ports via URL parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the TypeScript utility library. The suite now reports 60 pass / 0 fail (was 44 pass / 16 fail). No test files were modified and no dependencies were added.
Changes
src/calculator.tsdividethrowsError("Division by zero")when the divisor is0instead of returningInfinity.src/string-utils.tswordCountsplits on a whitespace regex so consecutive spaces don't create empty tokens;truncateimplemented (word-boundary cut, ellipsis counts towardmaxLength, returns input unchanged when within limit).src/task-manager.tsremovereturnsfalsefor unknown ids;updateapplies partial updates and returnsfalsefor unknown ids;sortByorders priority high→medium→low andcreatedAtoldest-first (non-mutating).src/date-utils.tsformatRelativeusesMath.roundfor the day boundary so 36 hours ago renders as "2 days ago".src/validator.tsisEmailaccepts long TLDs (e.g.user@example.museum);isUrlaccepts URLs with a port via theURLparser.Verification
bun test→ 60 pass / 0 fail, 70 expect() calls.Assumptions
🤖 Generated with QuantCode Agent